Let cts can skip commented cases in caselist file #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new else if in parseCaseList() to skip commented line of caselist file. With this we can skip some less important test cases that may cause system hang or crash and let the whole test finish. Signed-off-by: Julia Zhang <[email protected]>
|
|
|
@lordalcol @nico @ShabbyX Would you mind help to review this patch? |
|
This probably works ok for a while, but wouldn't it be a hassle to keep the mustpass list in sync with upstream where you have locally / downstream commented some lines out? May I suggest instead adding a step to your CI / runner that would:
The advantage of doing the above is that you have more control over how to suppress tests. For example, the suppression file could include globs (like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new else if in parseCaseList() to skip commented line of caselist file. With this we can skip some less important test cases that may cause system hang or crash and let the whole test finish.